Skip to content

remote-host as last position argument#38

Merged
goodboy merged 1 commit into
SIPp:masterfrom
y-luis-rojo:hotfix/sipp-command-argument-order
Aug 21, 2018
Merged

remote-host as last position argument#38
goodboy merged 1 commit into
SIPp:masterfrom
y-luis-rojo:hotfix/sipp-command-argument-order

Conversation

@y-luis-rojo
Copy link
Copy Markdown
Contributor

Generated sipp call (using a custom scenario): sipp 10.22.22.20:5060 -i 10.22.22.191 -p 5060 -bind_local 10.22.22.191 -sf normal_registration-0000_uas.xml -r 1 -m 1 -inf users.csv seems wrong since the remote server address is the last argument sipp receives (check documentation). In fact running that command in the commend line, scenario also fails.

Nevertheless, changing just the first argument to the last position: sipp -sf normal_registration-0000_callee.xml -r 1 -m 1 -bind_local 10.22.22.191 -i 10.22.22.191 -inf users.csv -p 5060 10.22.22.20:5060, in the command line, it ends successfully.

@goodboy
Copy link
Copy Markdown
Member

goodboy commented Aug 20, 2018

check documentation

Wowee I didn't realize the docs had been improved so much 👍 !

Thanks again @y-luis!

Weird we never ran into this problem in CI or any production uses for that matter, heh.
I'm guessing maybe this another one of those SIPp version specific quirks?

I for one have always stuck the destaddr as the first arg when running sipp manually but maybe something has changed. If you know offhand it'd be good to know which version this started failing and if pysipp is dumping an error it'd be good to log that here for people who might run into this if they upgrade sipp without upgrading pysipp.

@goodboy goodboy requested a review from vodik August 20, 2018 21:36
@goodboy
Copy link
Copy Markdown
Member

goodboy commented Aug 21, 2018

@y-luis hey, just looking at the history here. Do you mind doing a git rebase upstream/master (or whatever you've called this remote if not upsgtream) just so we don't get the duplicate commits in this branch's history.

Thanks!

@y-luis-rojo y-luis-rojo force-pushed the hotfix/sipp-command-argument-order branch 2 times, most recently from ecb54bd to 68ed8ab Compare August 21, 2018 08:06
@y-luis-rojo
Copy link
Copy Markdown
Contributor Author

git rebase done.

Fix sipp build. Test with default Trusty.
@y-luis-rojo y-luis-rojo force-pushed the hotfix/sipp-command-argument-order branch from 68ed8ab to 4c955a0 Compare August 21, 2018 08:28
@goodboy goodboy merged commit 8d937bf into SIPp:master Aug 21, 2018
@y-luis-rojo y-luis-rojo deleted the hotfix/sipp-command-argument-order branch August 22, 2018 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants