Match 97% of Mogucchi#1899
Merged
ThatNintendoNerd merged 16 commits intoSMGCommunity:masterfrom Apr 7, 2026
Merged
Conversation
Report for RMGK01 (cd8a11f - 44bb9af)📈 Matched code: 46.71% (+0.09%, +5020 bytes) ✅ 42 new matches
...and 12 more new matches 📈 4 improvements in unmatched items
|
ThatNintendoNerd
requested changes
Apr 7, 2026
src/Game/Enemy/MogucchiHill.cpp
Outdated
| @@ -0,0 +1,5 @@ | |||
| #include "Game/Enemy/MogucchiHill.hpp" | |||
| #include "Game/LiveActor/LiveActor.hpp" | |||
Collaborator
There was a problem hiding this comment.
This include directive is redundant, as the corresponding header file already includes it.
src/Game/Enemy/Mogucchi.cpp
Outdated
Comment on lines
+382
to
+385
| bool isDown = false; | ||
| if (isNerve(&MogucchiNrvDown::sInstance) || isNerve(&MogucchiNrvAppearDown::sInstance) || isNerve(&MogucchiNrvDive::sInstance)) { | ||
| isDown = true; | ||
| } |
Collaborator
There was a problem hiding this comment.
Can this be simplified to the following?
bool isDown = isNerve(&MogucchiNrvDown::sInstance) || isNerve(&MogucchiNrvAppearDown::sInstance) || isNerve(&MogucchiNrvDive::sInstance);
Contributor
Author
|
Requested changes should have been addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes new inlines for TRotation3 that are needed for certain matches in this TU. Also includes very early
MogucchiHillclass definitions, which are most likely wrong but are not in the scope of this PR.