Skip to content

Add generic instrument for making finder charts, update tests, fix most modules type annotations.#14

Merged
emirkmo merged 5 commits intomainfrom
fix_type_annot
Nov 16, 2022
Merged

Add generic instrument for making finder charts, update tests, fix most modules type annotations.#14
emirkmo merged 5 commits intomainfrom
fix_type_annot

Conversation

@emirkmo
Copy link
Contributor

@emirkmo emirkmo commented Nov 15, 2022

Also:

  1. Updates tests: End to end test with several configurations of 20lao. Add unit tests for new instrument. Better reporting.
  2. Makes everything but the plotting module pass basic type annotations via pyright/pylance.
  3. Makes initialization of Target/Plan more robust and narrow down types.
  4. Several more minor fixes (Ignore warnings, move parse to parser module
  5. black code style.

@emirkmo emirkmo marked this pull request as ready for review November 15, 2022 21:37
@emirkmo emirkmo merged commit 66da19b into main Nov 16, 2022
@emirkmo emirkmo deleted the fix_type_annot branch November 16, 2022 12:53
@emirkmo emirkmo linked an issue Nov 16, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add generic instrument for finder chart.

1 participant