Clean references#2
Merged
rhandberg merged 10 commits intoSNflows:develfrom Jun 30, 2020
emirkmo:clean_references
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #2 +/- ##
==========================================
- Coverage 19.08% 18.85% -0.23%
==========================================
Files 14 14
Lines 964 981 +17
==========================================
+ Hits 184 185 +1
- Misses 780 796 +16
Continue to review full report at Codecov.
|
Just changing the distance check from pixels to degrees
- Changed default peakmax to be undefined (None). - Changed weakest DAOFind threshold to be relative instead of fixed absolute value.
rhandberg
pushed a commit
that referenced
this pull request
Apr 22, 2021
Rasmus Comments, flake8 things. Correct Branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are my initial change to make a clean reference star list. This involves the nonlinear cut-off parameter added to image class. And then using the DAOStarFinder comparison more strictly for now, with a back-up in case it fails.
I also added a function for removing targets within X distance and commented out reference code for filtering based on daofind parameters.
I also added Jupyter notebooks/lab misc to .gitignore.