Skip to content

add parallel execution as test_par.py:#3

Closed
emirkmo wants to merge 1 commit intoSNflows:develfrom
emirkmo:parallelV1
Closed

add parallel execution as test_par.py:#3
emirkmo wants to merge 1 commit intoSNflows:develfrom
emirkmo:parallelV1

Conversation

@emirkmo
Copy link
Contributor

@emirkmo emirkmo commented Jul 14, 2020

Adding parallelization (simple way for now). Tested and improves speed pretty linearly with cores on the machine.

Adds a simple test_par.py script that you can run, similar to run_photometry.py, that allows parallelization, will use number of cores specified, or the max available, whichever is lesser. In the background we're currently just calling run_photometry.py in parallel executions because I don't really know how to handle the logging in parallel in the same script yet. But this works for now and we can implement it into run_photometry.py or improve it in the future if desired.

@codecov-commenter
Copy link

Codecov Report

Merging #3 into devel will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel       #3   +/-   ##
=======================================
  Coverage   18.78%   18.78%           
=======================================
  Files          14       14           
  Lines         990      990           
=======================================
  Hits          186      186           
  Misses        804      804           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90927dc...ba83206. Read the comment docs.

@emirkmo emirkmo changed the title add parallel exection as test_par.py: add parallel execution as test_par.py: Jul 14, 2020
@rhandberg
Copy link
Contributor

Already implemented in run_photometry.py

@rhandberg rhandberg closed this Sep 8, 2020
@emirkmo emirkmo deleted the parallelV1 branch December 15, 2020 15:19
rhandberg pushed a commit that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants