Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #3 +/- ##
=======================================
Coverage 18.78% 18.78%
=======================================
Files 14 14
Lines 990 990
=======================================
Hits 186 186
Misses 804 804 Continue to review full report at Codecov.
|
Contributor
|
Already implemented in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding parallelization (simple way for now). Tested and improves speed pretty linearly with cores on the machine.
Adds a simple test_par.py script that you can run, similar to run_photometry.py, that allows parallelization, will use number of cores specified, or the max available, whichever is lesser. In the background we're currently just calling run_photometry.py in parallel executions because I don't really know how to handle the logging in parallel in the same script yet. But this works for now and we can implement it into run_photometry.py or improve it in the future if desired.