Conversation
Contributor
Author
|
@rhandberg tagging you so that you can pull this when it's ready and if it looks ok. The refactor also had me mess with the github actions so there are some with the regular release things. |
Contributor
Author
|
Tests failed due to LFS bandwidth, which I upgraded now.. |
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 29.14% 29.14% -0.01%
==========================================
Files 36 36
Lines 2628 2632 +4
==========================================
+ Hits 766 767 +1
- Misses 1862 1865 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm in the middle of a big refactor of Devel but needed to add RATIR as an instrument, so I am hoping I can merge this into Master after some tests.
@lgalbany should let me know though if the headers will be correct or not for the FILTER, or if I should also add in logic for dealing with their dual filter name headers.
It has also been added as site with id=23 on the flows website/database.