Skip to content

fix(navigation): faulty api calls (RDFA-433)#64

Merged
rema-soptim merged 7 commits intomainfrom
fix/RDFA-433-faulty-api-calls-on-import-delete
Apr 13, 2026
Merged

fix(navigation): faulty api calls (RDFA-433)#64
rema-soptim merged 7 commits intomainfrom
fix/RDFA-433-faulty-api-calls-on-import-delete

Conversation

@rema-soptim
Copy link
Copy Markdown
Collaborator

@rema-soptim rema-soptim commented Mar 30, 2026

Description

Refactored package navigation to prevent faulty api calls
Also removed some duplicated api calls

Test Checklist

General Behavior

  • Components reload automatically when data changes
  • Editing features are disabled in readonly datasets
  • Dialogs pre-select current dataset/graph
  • Required fields are validated in dialogs
  • Discarding unsaved changes opens a discard cancel confirm dialog

Global MenuBar

  • Navigate to home page works
  • File menu:
    • Import → Graph/SHACL works
    • Export → Graph/SHACL works
    • Share Snapshot works
    • Delete → Dataset/Graph works
  • Edit menu:
    • New → Class works
    • New → Package works
    • Edit/View → Create/Edit/View Ontology works
    • Edit/View → Package works
    • Undo/Redo (Ctrl+Z / Ctrl+Y) works
    • Enable/Disable editing works
    • Manage/View namespaces works
    • Delete → Ontology/Package works
  • View menu:
    • Changelog opens and shows current graph
    • Compare Graphs opens
    • Full SHACL works
  • Help menu:
    • Help link works
    • Submit Feedback link works
    • About navigation works

Welcome Page

  • Navigation to Editor works
  • Tips are displayed
  • Security and data information displayed
  • Copyright and version information displayed

Editor - MenuBar

  • Search function works with all filters (All Datasets, Current Dataset, Current Graph, Current Package)
  • Search finds classes, attributes, associations, packages
  • "Enable Editing" button appears for readonly datasets

Editor - Navigation

  • Hierarchical display (Datasets → Graphs → Packages) works
  • Selection is highlighted
  • Selecting a class does not change dataset/graph/package selection
  • Class selection stays open/highlighted when switching dataset/graph/package
  • Datasets and graphs are collapsible
  • Single click selects; double click or chevron toggles expand/collapse
  • State persists on reload (non-browser)
  • Context menus act on the dataset/graph/package they were opened on
  • Hover labels show prefixes when configured
  • Dataset context menu:
    • Import graph works (disabled in readonly datasets)
    • Share Snapshot works
    • Enable/Disable editing works
    • Manage/View namespaces works
    • Delete dataset works
  • Graph context menu:
    • New package works (disabled in readonly datasets)
    • Undo/Redo works (only enabled when available)
    • Create Ontology
    • Edit Ontology (View Ontology in readonly)
    • Delete Ontology
    • Changelog navigation works
    • Compare dialog works
    • SHACL import/export/full view works (import disabled in readonly datasets)
    • Export graph works
    • Delete graph works (disabled in readonly datasets)
  • Package context menu:
    • Create new class works (disabled in readonly datasets)
    • View/Edit package works
    • Copy URL works
    • Delete package works (disabled for external/default packages and readonly datasets)
  • Class context menu:
    • Open class (editor) works
    • SHACL works
    • Delete class works (disabled in readonly datasets)

Editor - Package View

  • Class diagram displays correctly
  • Moving nodes works and layout changes persist after reload
  • Loading animation shows while loading
  • Info cards show when no package or no classes available
  • Drag and zoom diagram works
  • "Reset View" button works
  • "Filter View" works
  • "Reset Layout" button resets diagram to auto-generated layout
  • Click on class opens class editor

Editor - Class Editor

  • Display and edit class properties: UUID (readonly), Label, Namespace, Package, Derived from, Abstract, Stereotypes, Attributes, Associations, Comment
  • Delete class works
  • Save changes works
  • Discard changes works
  • Attribute Editor works
  • Association Editor works
  • attribute/association SHACL View works
  • Class SHACL View works

Prefixes Page

  • View, add, remove and edit namespaces works

Changelog Page

  • Select graph and display write operations works
  • Operations shown in reverse chronological order
  • Detailed view of changed triples works
  • Restoring graph to a version works

Compare Page

  • Compare two graphs works

Copy link
Copy Markdown
Collaborator

@kiph-soptim kiph-soptim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed
Tested:

  • Graph Context Menu: Undo/Redo does not work

@rema-soptim rema-soptim force-pushed the fix/RDFA-433-faulty-api-calls-on-import-delete branch from 71531c6 to 7a52aca Compare April 7, 2026 11:00
Copy link
Copy Markdown
Collaborator

@kiph-soptim kiph-soptim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rema-soptim rema-soptim force-pushed the fix/RDFA-433-faulty-api-calls-on-import-delete branch from 7a52aca to d4dbca9 Compare April 13, 2026 07:45
@rema-soptim rema-soptim merged commit 04858dd into main Apr 13, 2026
6 checks passed
@rema-soptim rema-soptim deleted the fix/RDFA-433-faulty-api-calls-on-import-delete branch April 13, 2026 07:51
kiph-soptim pushed a commit that referenced this pull request Apr 14, 2026
* refactored navigation to remove faulty api calls

* fixed bugs where:
- default packages were always shown as empty
- no reload happened on enable/disable editing
also added hot reload for undo/redo

* fixed bug, where the package editor didn't work

* fixed bug, where the ontology editor didn't reload properly

* fixed bug where graph navigation section was not updated on modifying data

* fixed bug where undo redo didn't trigger a reload in the class editor
kiph-soptim pushed a commit that referenced this pull request Apr 15, 2026
* refactored navigation to remove faulty api calls

* fixed bugs where:
- default packages were always shown as empty
- no reload happened on enable/disable editing
also added hot reload for undo/redo

* fixed bug, where the package editor didn't work

* fixed bug, where the ontology editor didn't reload properly

* fixed bug where graph navigation section was not updated on modifying data

* fixed bug where undo redo didn't trigger a reload in the class editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants