feature: add custom diagrams (RDFA-364)#71
Open
tarn-soptim wants to merge 10 commits intomainfrom
Open
Conversation
5c685f1 to
b6ae184
Compare
58212fc to
84cb86d
Compare
rema-soptim
requested changes
Apr 28, 2026
Collaborator
There was a problem hiding this comment.
First few things i noticed:
- deleting a custom dataset view doesn't work
- dataset views don't render
- dataset views are not expanded when creating them (could be intentional but I think it would make sense)
- When selecting a class that exists in multiple views only the one clicked at is highlighted in the package navigation, instead of all occurrences
- I think it feels strange that it's not possible to onclick highlight the dataset/profile navigation entries like for datasets/graphs, even though it probably has no use.
- Would it make sense to not show the custom diagram section, when it's empty? And move the create functionality to the dataset/graph context menu. To me it feels visually disruptive when it's not used, especially since it reoccurs for every graph and has a unique spacing because of the separator
- Maybe the option for "Add to Profile Diagram" and "Add to Dataset Diagram" in the class context menu should be disabled when there are no existing diagrams or let the user create a new diagram from here too.
- Missing header text for the create profile and dataset diagram dialog.
- Rn it's only possible to select a class in the create diagram menu by clicking the checkbox directly, maybe it would make sense to use the whole class entry as the button and the checkbox only as the indicator.
- Double clicking a checkbox too fast expands/closes the dataset/graph in the create dialogs
- The console is spammed with "invalid ownership mutation" in the create dialogs
- There is a "deselect all" button, but not a "select all"
- The filter view dialog doesn't make sense for custom diagrams
This is not a complete test, only the things i noticed when checking out whats new, before doing the actual review.
rema-soptim
requested changes
Apr 30, 2026
|
|
||
| private String getDiagramName(DiagramLayout diagramLayout, GraphIdentifier graphIdentifier, CIMCollection cimCollection, UUID diagramUUID) { | ||
| if (diagramUUID == diagramLayout.getDefaultPackageMRID().getUuid()) { | ||
| return graphIdentifier.getGraphUri() + "/" + DEFAULT_PACKAGE_NAME; |
Collaborator
There was a problem hiding this comment.
Shouldn't this be separated by '#'?
Collaborator
Author
There was a problem hiding this comment.
i only extracted that bit from existing code, so i would assume its correct if it has been working so far?
| selectedDataset: new StateValuePair(), | ||
| selectedGraph: new StateValuePair(), | ||
| selectedPackageUUID: new StateValuePair(), | ||
| selectedCustomDiagramUUID: new StateValuePair(), |
Collaborator
There was a problem hiding this comment.
I feel like its kinda strange having 2 states that can never be turned on at the same time, maybe it's possible to unify them. But im not sure if this creates other problems im not thinking about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test Checklist
General Behavior
Global MenuBar
Welcome Page
Editor - MenuBar
Editor - Navigation
Editor - Package View
Editor - Class Editor
Prefixes Page
Changelog Page
Compare Page