-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
- Issues must always be opened against main. Don’t open issues like “this thing is broken on branch X”, when that branch is 10 commits behind and 38 changes ahead from main. It may also be useful to provide the hash of the latest commit when you open the issue.
- Branches should live for the shortest time possible. As soon as you have a self-contained feature, open a pull request.
- Once a pull request is open, finishing the review and merging it becomes top priority.
- Don’t merge secondary branches into other secondary branches. First, it breaks rule 2. Second, it makes reviews a nightmare.
- Before opening a pull request, make sure your changes are clean, no debug code.
- Put some effort in refactoring code before opening a Pull Request. Garbage code can get your PR rejected.
- I know, reviewing others’ code takes time and isn't the most exciting task, but it’s essential for a solid codebase. If you see a pull request with no requested changes that hasn’t been merged yet, it’s your turn to review it.
Metadata
Metadata
Assignees
Labels
No labels