ID-167: Upload zip#74
Merged
Artem-Goldenberg merged 4 commits intotask181_train_with_dataloaderfrom Dec 19, 2023
Merged
Conversation
Artem-Goldenberg
force-pushed
the
task167_upload_zip
branch
3 times, most recently
from
bed1888 to
2a64827
Compare
Artem-Goldenberg
changed the base branch from
main
to
task181_train_with_dataloader
Artem-Goldenberg
force-pushed
the
task167_upload_zip
branch
from
2a64827 to
76078c4
Compare
Artem-Goldenberg
force-pushed
the
task167_upload_zip
branch
from
76078c4 to
014e2f7
Compare
Artem-Goldenberg
force-pushed
the
task167_upload_zip
branch
from
014e2f7 to
2e44bd7
Compare
Artem-Goldenberg
force-pushed
the
task167_upload_zip
branch
from
2e44bd7 to
d95432c
Compare
lpetrov02
requested changes
Dec 19, 2023
Contributor
lpetrov02
left a comment
lpetrov02
left a comment
There was a problem hiding this comment.
В одном месте я прям так сильно не понял, в остальном - норм)
| std::vector<char> file_data(info.size); | ||
| zip_fread(file, file_data.data(), info.size); | ||
| fout.write(file_data.data(), info.size); | ||
| char *file_data = new char[info.size]; |
Contributor
Author
There was a problem hiding this comment.
да точно, забыла delete, ну не зря мы все таки смотрим
server/api/server.cpp
Outdated
| char *file_data = new char[info.size]; | ||
| zip_fread(file, file_data, info.size); | ||
| fout.write(file_data, info.size); | ||
| fout.close(); |
Contributor
There was a problem hiding this comment.
Кажется, один из смыслов использования std::ofstream - это как раз то, что закроется оно само в деструкторе объекта
Contributor
Author
There was a problem hiding this comment.
а да? ну окей тогда можно убрать
lpetrov02
added a commit
that referenced
this pull request
Dec 20, 2023
* Started migration from Data2dLayer to DataLayer Makes preparations for metrics logging on python Functionality for c++ http added, but not working yet Adds saving train metrics Adds saving train metrics and responding with PNG Adaptates code for new 4D blob cpprest CI support Add load possibility for zip Add load possibility for png on predict ------- GRA-122: Data loader implementation (#67) Data loader implementation ------- ID-154: Loss type selection (#70) * Add loss type selection * Add loss type selection * Remove layer-class loss * Clean up Loss type * Make format ------- ID-171: Fix input selection (#69) * Fix input selection * Clean up fix input selection ------- Change train and predict for zip file case Starts fixing train Fixes train with dataloader It's not fucking working :( (x3) server train fix Fixes train and predcit * Follow up review * Follow up review * ID-167: Upload zip (#74) * Fixes graph tests * Fixes DataLayer --------- Co-authored-by: lpetrov02 <lpetrov02@mail.ru> Co-authored-by: Artem Goldenberg <58527023+Artem-Goldenberg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Тесты не проходят из-за тестов Графа, Леня пофиксил плиз
Заливаю в большой пр, чтобы там пофиксилась сборка
Добавил новый метод к update_model теперь есть еще PATCH. Который загружает файл csv или zip на сервер.
Для предикт будет в следующем пре уже
Большие файлы с 50 мб загружает