fix!: allow expressions in scd type 2 model unique keys#2164
Merged
Conversation
eakmanrq
force-pushed
the
eakmanrq/scd_type_2_unique_key_expression
branch
from
2ed8415 to
85a03fe
Compare
tobymao
approved these changes
Feb 21, 2024
eakmanrq
force-pushed
the
eakmanrq/scd_type_2_unique_key_expression
branch
from
85a03fe to
239242d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for expressions in the list of columns in unique keys. Adding this in order to support dbt's ability to handle a single expression (SQLMesh now supports a list of them).
Since SQLMesh supports a list of columns, the number of use cases should be lower and therefore this might just be for rare cases in SQLMesh native. As a result not documenting this for now.