Feat!: Support pre-post statements in python models at creation time#2977
Merged
themisvaltinos merged 8 commits intomainfrom Aug 8, 2024
Merged
Feat!: Support pre-post statements in python models at creation time#2977themisvaltinos merged 8 commits intomainfrom
themisvaltinos merged 8 commits intomainfrom
Conversation
georgesittas
reviewed
Aug 2, 2024
themisvaltinos
force-pushed
the
themis/prepost_statements
branch
from
49adc9e to
8aedc9a
Compare
Contributor
Author
|
addressed comments and added functionality to support jinjas. Thank you @georgesittas, when you have time if you could take another look a change in particular that I'm not entirely sure if it might have unforeseen consequences is replacing the |
georgesittas
reviewed
Aug 6, 2024
georgesittas
approved these changes
Aug 6, 2024
themisvaltinos
force-pushed
the
themis/prepost_statements
branch
from
527477a to
30d607a
Compare
themisvaltinos
changed the title
georgesittas
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update introduces the ability to enable pre- and post-statements in python models that can be executed during the table creation phase, fixes: #2866
The SqlBased model renderers has been moved to the
_Modelclass, so that the logic can be reused by python models. Also to support macro calls in the pre- and post-statements, the python environment is updated with the referenced macros (similarly to sql models).