Conversation
izeigerman
reviewed
Feb 5, 2025
izeigerman
reviewed
Feb 5, 2025
izeigerman
reviewed
Feb 5, 2025
tobymao
reviewed
Feb 5, 2025
tobymao
reviewed
Feb 5, 2025
tobymao
reviewed
Feb 5, 2025
cbdeab5 to
8f456d4
Compare
8f456d4 to
e60106e
Compare
e60106e to
c90f22c
Compare
2c3e92e to
7116a75
Compare
VaggelisD
commented
Feb 24, 2025
VaggelisD
commented
Feb 24, 2025
Contributor
Author
|
PS: |
tobymao
reviewed
Feb 25, 2025
tobymao
reviewed
Feb 25, 2025
tobymao
reviewed
Feb 25, 2025
tobymao
reviewed
Feb 25, 2025
tobymao
reviewed
Feb 25, 2025
f9c6ae2 to
7beea0b
Compare
tobymao
reviewed
Feb 26, 2025
tobymao
reviewed
Mar 3, 2025
tobymao
reviewed
Mar 4, 2025
tobymao
reviewed
Mar 4, 2025
tobymao
approved these changes
Mar 4, 2025
0e7a4e0 to
cef2ff6
Compare
izeigerman
reviewed
Mar 4, 2025
izeigerman
reviewed
Mar 4, 2025
izeigerman
reviewed
Mar 4, 2025
izeigerman
reviewed
Mar 4, 2025
izeigerman
reviewed
Mar 4, 2025
6ed1217 to
0f6250d
Compare
georgesittas
reviewed
Mar 6, 2025
f4a1c6b to
8280209
Compare
izeigerman
reviewed
Mar 6, 2025
izeigerman
reviewed
Mar 6, 2025
izeigerman
reviewed
Mar 6, 2025
izeigerman
approved these changes
Mar 6, 2025
Collaborator
izeigerman
left a comment
There was a problem hiding this comment.
Let's move violated_rules into the QueryRenderer. LGTM otherwise 👍 Let's make sure to follow-up with docs. Great work!
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3753
This PR introduces a new interface for a general purpose
Modellinter:Rulechecks for a specific lint error; If a violation is found, aRuleViolationis created with the proper contextRuleSets; EachRuleSetis a mapping fromRuleclass name ->Ruleclass.Linterapplies theRuleSetson the model and outputs warnings / raises errors depending on their severityThe linter configuration along with the default values is the following:
This is to preserve the behavior of
QueryRenderertoday; For this matter,validate_queryis deprecated and instead the corresponding checks are implemented as rules in the Linter.On a model granularity, rules can be ignored by the new
ignored_rulesattribute:Users can implement their own lint rules in a
linter/directory by subclassingRule; These will be automatically picked up at load time: