Fix: Use the dialect when parsing the environment statements for the python_env#3939
Merged
themisvaltinos merged 2 commits intomainfrom Mar 4, 2025
Merged
Fix: Use the dialect when parsing the environment statements for the python_env#3939themisvaltinos merged 2 commits intomainfrom
themisvaltinos merged 2 commits intomainfrom
Conversation
georgesittas
approved these changes
Mar 4, 2025
Co-authored-by: Jo <46752250+georgesittas@users.noreply.github.com>
themisvaltinos
force-pushed
the
themis/fix_parse_dialect
branch
from
2dc6dde to
d210a9f
Compare
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
…python_env (#3939) Co-authored-by: Jo <46752250+georgesittas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the dialect when parsing the statements to ensure that dialect-specific statements, such as the one below in bigquery, are handled correctly when constructing the python_env:
thanks for catching this @georgesittas