Conversation
…o the partitioned_by columns
erindru
commented
Mar 4, 2025
| # This allows the user to opt out of automatic time_column injection | ||
| # by setting `partition_by_time_column false` on the model kind | ||
| if ( | ||
| hasattr(self.kind, "partition_by_time_column") |
Collaborator
Author
There was a problem hiding this comment.
Note that this is deliberately a hasattr check so I can utilize this property on a custom materialization
erindru
changed the title
izeigerman
approved these changes
Mar 5, 2025
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
…to the partitioned_by columns (#3941)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you have a model something like:
Then the
dscolumn would be automatically added to thepartitioned_bycolumns whether you wanted it to or not.This PR allows you to opt-out with the following syntax:
(the default is
trueto keep the existing behaviour)