Fix: State sync snapshot count() quoting#3954
Merged
Conversation
erindru
commented
Mar 7, 2025
.circleci/continue_config.yml
Outdated
| branches: | ||
| only: | ||
| - main | ||
| #filters: |
Collaborator
Author
There was a problem hiding this comment.
I'll uncomment this prior to merge, want to see if the new test picks up any issues on the other cloud engines
tobymao
approved these changes
Mar 7, 2025
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3903 introduced a subtle bug where the snapshot count queries stopped being quoted. This meant that on engines like Snowflake,
_snapshotswas interpreted as_SNAPSHOTSwhich caused migration to fail.This PR fixes the issue and adds a test to detect this in future