Fix: Batch intervals in DAG order to make sure that parent snapshot signals are respected by their children#3956
Merged
izeigerman merged 1 commit intomainfrom Mar 7, 2025
Conversation
…ignals are respected by their children
georgesittas
approved these changes
Mar 7, 2025
izeigerman
added a commit
that referenced
this pull request
Mar 7, 2025
…ignals are respected by their children (#3956)
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
…ignals are respected by their children (#3956)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were batching intervals in an arbitrary order, which could randomly result in child intervals running even when the same interval was unavailable in its parent due to the signal condition not being met.
This fix ensures that batches are computed in DAG order.
Huge kudos to @plaflamme for providing a test case which reproduces the issue (#3951)