Fix: Fail the plan command if the selector expression doesn't return any models#3968
Merged
izeigerman merged 1 commit intomainfrom Mar 11, 2025
Merged
Fix: Fail the plan command if the selector expression doesn't return any models#3968izeigerman merged 1 commit intomainfrom
izeigerman merged 1 commit intomainfrom
Conversation
izeigerman
force-pushed
the
fix-fail-plan-on-empty-selector
branch
from
3b95a5d to
168822f
Compare
erindru
approved these changes
Mar 11, 2025
tobymao
approved these changes
Mar 11, 2025
Contributor
tobymao
left a comment
tobymao
left a comment
There was a problem hiding this comment.
you didn't want to do this at the selector level and check each node?
Collaborator
Author
@tobymao, I think we want to warn at the selector level but decision to fail should be made downstream IMHO |
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent unexpected behavior and confusing errors we should fail the plan immediately if we discover that the selector expressions provided by the user don't return any models.