Merged
Conversation
kelsin
approved these changes
Mar 25, 2025
georgesittas
approved these changes
Mar 25, 2025
b8773f4 to
8f2b7ee
Compare
Contributor
Author
|
Note: #4032 actually solves the initial problem. This PR should now be rebased on top of it & divert the output to the new linter check/job. |
ba0b56d to
7e6eba6
Compare
7e6eba6 to
2cf6f51
Compare
eakmanrq
reviewed
Mar 29, 2025
eakmanrq
reviewed
Mar 29, 2025
Collaborator
eakmanrq
left a comment
There was a problem hiding this comment.
Please update docs to document the new linter bot output and put a screenshot of the linter output from this PR in the examples sections so users can see that this functionality is included.
eakmanrq
approved these changes
Mar 31, 2025
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the CI/CD bot with a new check specific to the linter.
For the new check, we have the following cases:
If linting is disabled, the check does not run at all
If linting is fully successful, the check passes with
Linter SuccessIf linting shows error/warning outputs, the summary is as shown below:
Linter errors