Skip to content

Fix: Fail instead of warn if cleaning up an environment failed #4054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
izeigerman merged 1 commit into from
Mar 31, 2025
Merged

Fix: Fail instead of warn if cleaning up an environment failed #4054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sqlmesh/core/state_sync/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from sqlmesh.core.console import Console
from sqlmesh.core.dialect import schema_
from sqlmesh.core.environment import Environment
from sqlmesh.utils.errors import SQLMeshError

if t.TYPE_CHECKING:
from sqlmesh.core.engine_adapter.base import EngineAdapter
Expand Down Expand Up @@ -46,7 +47,9 @@ def cleanup_expired_views(
if console:
console.update_cleanup_progress(schema.sql(dialect=adapter.dialect))
except Exception as e:
logger.warning("Failed to drop the expired environment schema '%s': %s", schema, e)
raise SQLMeshError(
f"Failed to drop the expired environment schema '{schema}': {e}"
) from e
for expired_view in {
snapshot.qualified_view_name.for_environment(
environment.naming_info, dialect=adapter.dialect
Expand All @@ -60,7 +63,9 @@ def cleanup_expired_views(
if console:
console.update_cleanup_progress(expired_view)
except Exception as e:
logger.warning("Failed to drop the expired environment view '%s': %s", expired_view, e)
raise SQLMeshError(
f"Failed to drop the expired environment view '{expired_view}': {e}"
) from e


def transactional() -> t.Callable[[t.Callable], t.Callable]:
Expand Down