Skip to content

Fix: Set allow_partials models for all dbt model kinds, including full refresh models #4060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
izeigerman merged 1 commit into from
Mar 31, 2025
Merged

Fix: Set allow_partials models for all dbt model kinds, including full refresh models #4060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sqlmesh/dbt/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,10 +556,12 @@ def to_sqlmesh(

kind = self.model_kind(context)
allow_partials = model_kwargs.pop("allow_partials", None)
if allow_partials is None and (
kind.is_incremental_unmanaged or kind.is_incremental_by_unique_key
if (
allow_partials is None
and kind.is_materialized
and not kind.is_incremental_by_time_range
):
# Set allow_partials to True for dbt incremental models to preserve the original semantics.
# Set allow_partials to True for dbt models to preserve the original semantics.
allow_partials = True

model = create_sql_model(
Expand Down
4 changes: 2 additions & 2 deletions tests/dbt/test_transformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1461,7 +1461,7 @@ def test_refs_in_jinja_globals(sushi_test_project: Project, mocker: MockerFixtur
}


def test_dbt_incremental_allow_partials_by_default():
def test_allow_partials_by_default():
context = DbtContext()
context._target = SnowflakeConfig(
name="target",
Expand All @@ -1481,7 +1481,7 @@ def test_dbt_incremental_allow_partials_by_default():
materialized=Materialization.TABLE.value,
)
assert model.allow_partials is None
assert not model.to_sqlmesh(context).allow_partials
assert model.to_sqlmesh(context).allow_partials

model.materialized = Materialization.INCREMENTAL.value
assert model.allow_partials is None
Expand Down