Fix!: Propagate gateway variables to model tests#4102
Merged
Conversation
VaggelisD
force-pushed
the
vaggelisd/test_gateway_vars
branch
4 times, most recently
from
fa7c3a1 to
8f8b58a
Compare
georgesittas
reviewed
Apr 9, 2025
izeigerman
reviewed
Apr 9, 2025
Contributor
Author
|
The latter commit (d460f6f) brought the following changes:
|
VaggelisD
force-pushed
the
vaggelisd/test_gateway_vars
branch
from
c71693e to
e1ad483
Compare
izeigerman
reviewed
Apr 10, 2025
VaggelisD
force-pushed
the
vaggelisd/test_gateway_vars
branch
2 times, most recently
from
86362f0 to
99e6591
Compare
izeigerman
reviewed
Apr 11, 2025
izeigerman
reviewed
Apr 11, 2025
VaggelisD
force-pushed
the
vaggelisd/test_gateway_vars
branch
from
d28523e to
45c0f80
Compare
georgesittas
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4068
This PR addresses the following items:
[Fix] Feat!: Make model tests run concurrently #4047 did not properly handle cases where the model doesn't exist, the errors should be caught
[Fix] The testing module only takes
config.variablesinto account; This is now extended to also use the selected gateway's variables[Refactor] The APIs for loading & running tests are fragmented into multiple points e.g
run_model_testsandrun_tests. To address that, this PR attempts to unify the test loading+running logic.