Merged
Conversation
1d5e453 to
4262f64
Compare
4262f64 to
3b60eba
Compare
newtonapple
reviewed
Sep 25, 2025
Comment on lines
+227
to
+229
| exp.column("table_catalog").eq(exp.Literal.string(catalog_name.lower())), | ||
| exp.column("table_schema").eq(exp.Literal.string(schema_name.lower())), | ||
| exp.column("table_name").eq(exp.Literal.string(table_name.lower())), |
Contributor
There was a problem hiding this comment.
I assume the reason we lower case everything is because we are assuming Databricks users will be using Unity catalog? Is that always the case? I know some deployments still use hive metastore. If I remember correctly, it table names etc. can be case sensitive there.
Collaborator
Author
There was a problem hiding this comment.
The engine adapter itself assumes Unity Catalog. So we don't need to worry about hive metastore compatibility.
newtonapple
pushed a commit
that referenced
this pull request
Sep 29, 2025
newtonapple
pushed a commit
that referenced
this pull request
Sep 30, 2025
newtonapple
pushed a commit
that referenced
this pull request
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unique nuances of Databricks for grants:
Confirmed CI tests for Snow/Databricks pass.