chore: grant mixin and normalize#5447
Merged
eakmanrq merged 1 commit intoddai/grantsfrom Sep 29, 2025
Merged
Conversation
eakmanrq
force-pushed
the
eakmanrq/grant_mixin_and_normalize
branch
3 times, most recently
from
4d54568 to
c291761
Compare
erindru
reviewed
Sep 28, 2025
| assert 'GRANT INSERT ON "test_schema"."test_table" TO user3' in sql_calls | ||
| assert 'REVOKE SELECT ON "test_schema"."test_table" FROM old_user' in sql_calls | ||
| assert 'REVOKE UPDATE ON "test_schema"."test_table" FROM admin_user' in sql_calls | ||
| assert 'GRANT SELECT ON "test_schema"."test_table" TO "user1", "user2"' in sql_calls |
Collaborator
There was a problem hiding this comment.
Nice, the previous implementation that didn't quote was asking for trouble
erindru
approved these changes
Sep 28, 2025
eakmanrq
force-pushed
the
eakmanrq/grant_mixin_and_normalize
branch
from
c291761 to
4564c98
Compare
newtonapple
approved these changes
Sep 29, 2025
newtonapple
pushed a commit
that referenced
this pull request
Sep 29, 2025
newtonapple
pushed a commit
that referenced
this pull request
Sep 30, 2025
newtonapple
pushed a commit
that referenced
this pull request
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a mixin for grants that are using the information schema in order to share common logic.
Also properly normalizes the Grant Principle which is why there are quotes around the identifiers now.