Fix: dont try to serialize engine adapter to sql in macro template method#5455
Fix: dont try to serialize engine adapter to sql in macro template method#5455georgesittas merged 2 commits intoSQLMesh:mainfrom
Conversation
georgesittas
left a comment
There was a problem hiding this comment.
Good catch, thanks! This looks reasonable but will take a quick look to see if more things need to be excluded. The selected_models set seems a bit off too.
|
@z3z1ma actually, did you figure out what causes the memory spike? I'm not sure I understand yet. I had assumed that the issue was |
|
Its something hitting the Let me think, I bet if you had a snapshot from a blueprint model, there is some janky recursion/condition that blows things up recursively going into Try it on a blueprint model snapshot with 100 or so variants at least. That's where it was easy to see the downhill |
|
Gotcha. Will revisit this tomorrow morning, thanks for following up. That theory sounds plausible. |
|
Your theory is correct @z3z1ma: It eventually does fail, probably because |
No idea why this is happening but its a doozy, completely tanks sqlmesh. Seems to happen in blueprint model path (but do your due diligence if you investigate this). So anyone using blueprints would [probably] have memory spikes and program lock ups.