Closed
Conversation
georgesittas
force-pushed
the
jo/respect_quoting_setting_in_dbt
branch
9 times, most recently
from
84e8e59 to
573bfbc
Compare
themisvaltinos
approved these changes
Oct 7, 2025
Contributor
themisvaltinos
left a comment
themisvaltinos
left a comment
There was a problem hiding this comment.
lgtm, only the tests to adapt
georgesittas
force-pushed
the
jo/respect_quoting_setting_in_dbt
branch
3 times, most recently
from
3befbc7 to
67e8455
Compare
georgesittas
force-pushed
the
jo/respect_quoting_setting_in_dbt
branch
from
67e8455 to
edad6bc
Compare
georgesittas
force-pushed
the
jo/respect_quoting_setting_in_dbt
branch
from
edad6bc to
e2cab74
Compare
Contributor
Author
|
This has been deprioritized for now in favor of some other tasks. After discussing on Slack, we don't want to add quotes to every dbt model, because that's a massively breaking change. The idea we discussed was quoting only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.