Closed
Conversation
eakmanrq
force-pushed
the
eakmanrq/allow_batching_janitor_cleanup
branch
from
205a558 to
c23e6cd
Compare
newtonapple
reviewed
Oct 1, 2025
newtonapple
approved these changes
Oct 1, 2025
eakmanrq
force-pushed
the
eakmanrq/allow_batching_janitor_cleanup
branch
from
c23e6cd to
45e6f8e
Compare
Collaborator
Author
|
Going to re-implement with doing paging at the database level and let the user control the batch sizes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, janitor would always read all expired snapshots into memory. This is fine during normal operations but if for some reason janitor has not run for a while this can result in a lot of snapshots being read into memory.
This PR allows users to configure the janitor to batch up what is being processed. It does this by adjusting the "current_ts" (
batch_start) and then incrementing this by the providedbatch_size_seconds. So for example a user could provide the following to process the last 7 days of expired snapshots 1 day at a time: