Skip to content

fix: validate data_type for partition_by config #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toriwei merged 2 commits into from
Oct 8, 2025
Merged

fix: validate data_type for partition_by config #5491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e57d4c
validate data_type for partition_by config
toriwei Oct 6, 2025
5cf8d26
add test
toriwei Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sqlmesh/dbt/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,14 @@ def _validate_partition_by(
):
granularity = v["granularity"]
raise ConfigError(f"Unexpected granularity '{granularity}' in partition_by '{v}'.")
if "data_type" in v and v["data_type"].lower() not in (
"timestamp",
"date",
"datetime",
"int64",
):
data_type = v["data_type"]
raise ConfigError(f"Unexpected data_type '{data_type}' in partition_by '{v}'.")
return {"data_type": "date", "granularity": "day", **v}
raise ConfigError(f"Invalid format for partition_by '{v}'")

Expand Down
11 changes: 11 additions & 0 deletions tests/dbt/test_transformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1881,6 +1881,17 @@ def test_partition_by(sushi_test_project: Project):
)
assert model_config.to_sqlmesh(context).partitioned_by == []

with pytest.raises(ConfigError, match="Unexpected data_type 'string' in partition_by"):
ModelConfig(
name="model",
alias="model",
schema="test",
package_name="package",
materialized="table",
partition_by={"field": "ds", "data_type": "string"},
sql="""SELECT 1 AS one, ds FROM foo""",
)


@pytest.mark.xdist_group("dbt_manifest")
def test_partition_by_none(sushi_test_project: Project):
Expand Down