Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes state sync as a parameter from migration functions and passes engine adapter and schema directly instead. This simplifies the migration interface by only passing the specific components needed rather than the entire state sync object.
Key changes:
- Update migration function signatures to accept
engine_adapterandschemaparameters instead ofstate_sync - Remove extraction of engine adapter and schema from state sync within migration functions
- Update migration caller to pass engine adapter and schema directly
Reviewed Changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sqlmesh/migrations/*.py | Updated migration function signatures and removed state sync parameter extraction |
| sqlmesh/core/state_sync/db/migrator.py | Updated migration caller to pass engine adapter and schema directly |
| sqlmesh/core/state_sync/db/facade.py | Updated migrate call to pass schema instead of self |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
izeigerman
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has no logic changes.
Prior to this PR, we would pass state sync into migrations but this was really just done to get the engine adapter and schema out of it. Therefore this PR updates migrations to just require engine adapter and schema.