Skip to content

fix: remove state sync from migrate#5502

Merged
eakmanrq merged 1 commit intomainfrom
eakmanrq/remove_state_sync_migrate
Oct 8, 2025
Merged

fix: remove state sync from migrate#5502
eakmanrq merged 1 commit intomainfrom
eakmanrq/remove_state_sync_migrate

Conversation

@eakmanrq
Copy link
Collaborator

@eakmanrq eakmanrq commented Oct 7, 2025

This PR has no logic changes.

Prior to this PR, we would pass state sync into migrations but this was really just done to get the engine adapter and schema out of it. Therefore this PR updates migrations to just require engine adapter and schema.

@eakmanrq eakmanrq requested a review from Copilot October 7, 2025 22:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes state sync as a parameter from migration functions and passes engine adapter and schema directly instead. This simplifies the migration interface by only passing the specific components needed rather than the entire state sync object.

Key changes:

  • Update migration function signatures to accept engine_adapter and schema parameters instead of state_sync
  • Remove extraction of engine adapter and schema from state sync within migration functions
  • Update migration caller to pass engine adapter and schema directly

Reviewed Changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.

File Description
sqlmesh/migrations/*.py Updated migration function signatures and removed state sync parameter extraction
sqlmesh/core/state_sync/db/migrator.py Updated migration caller to pass engine adapter and schema directly
sqlmesh/core/state_sync/db/facade.py Updated migrate call to pass schema instead of self

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@eakmanrq eakmanrq merged commit 5edf538 into main Oct 8, 2025
35 of 37 checks passed
@eakmanrq eakmanrq deleted the eakmanrq/remove_state_sync_migrate branch October 8, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants