Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a BigQuery requirement where temporary tables need to be created with an explicit schema defined, ensuring they are created in the same location as the target physical schema.
- Updates temporary table creation in
_get_target_and_source_columnsto include the model's physical schema - Adds comprehensive test coverage to verify the temp table creation includes the correct schema
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sqlmesh/core/snapshot/evaluator.py | Modified temp table creation to include physical schema for BQ compatibility |
| tests/core/test_snapshot_evaluator.py | Added test to verify temp table creation with schema when using IGNORE change policies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
erindru
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BQ requires a schema defined when creating the temp table and we want to ensure it gets created in the same place as the target physical schema.
https://tobiko-data.slack.com/archives/C044BRE5W4S/p1760530731990029