Fix: Only selected models need to be promoted when --inlclude-unmodified flag is provided#5561
Merged
izeigerman merged 1 commit intomainfrom Oct 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where all models were being promoted when the --include-unmodified flag was used, even when specific models were selected. The fix ensures that only explicitly selected models are promoted when both flags are combined.
Key changes:
- Updated promotion logic to respect model selection when
--include-unmodifiedis provided - Restructured conditional logic to properly handle the combination of
include_unmodifiedandselected_models_to_backfill - Added comprehensive test coverage for both
--include-unmodifiedalone and combined with model selection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/core/integration/test_plan_options.py | Added two new test cases to verify promotion behavior with include_unmodified flag both standalone and combined with model selection |
| sqlmesh/core/plan/definition.py | Refactored promotion logic to correctly determine which snapshots should be promoted based on the combination of flags provided |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ied flag is provided
3ebed02 to
8a38c19
Compare
themisvaltinos
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5516