Fix: Require the cache for upstream deps in the scheduler#5571
Merged
izeigerman merged 1 commit intomainfrom Oct 31, 2025
Merged
Fix: Require the cache for upstream deps in the scheduler#5571izeigerman merged 1 commit intomainfrom
izeigerman merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the _find_upstream_dependencies method to make the cache parameter required instead of optional, removing the fallback initialization logic.
- Changed the
cacheparameter from optional to required - Removed the
cache = cache or {}initialization line
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
georgesittas
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cache or {}expression also returns a new empty dict if thecachevalue itself is an empty dict. So it basically ignored the value passed by the caller in the_dagmethod.