Fix: Embedded Model Type Should Not Accept Any Audit#5577
Merged
georgesittas merged 5 commits intoSQLMesh:mainfrom Dec 3, 2025
Merged
Fix: Embedded Model Type Should Not Accept Any Audit#5577georgesittas merged 5 commits intoSQLMesh:mainfrom
georgesittas merged 5 commits intoSQLMesh:mainfrom
Conversation
|
|
Contributor
|
@bearInTheRoad can you please remove the test from here https://github.com/TobikoData/sqlmesh/blob/main/examples/sushi_dbt/models/schema.yml#L45-L46 so that the migration_test passes |
Contributor
Author
Hey @izeigerman, I've removed this test in my branch but seems like migration_test fails because it's using code from the old tag. Should I update dbt/basemodel.py and skip ephemeral models for backward compatible purpose? Or do you prefer we stay this way and merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix #5546. After the fix, EMBEDDED model will reject any audit in model definition.