Adding missing operations#100
Merged
ahmed-irfan merged 15 commits intoSRI-CSL:masterfrom Nov 10, 2025
Merged
Conversation
…nstructor call of polynomial and potential issues with context missmatch.
9461393 to
421c5d2
Compare
|
After these changes, creating a constant polynomial like this: no longer works. The integer value now needs to be wrapped explicitly: I'm not sure this is the intended behavior. |
Contributor
Author
Of course not. Fixed. |
ahmed-irfan
approved these changes
Oct 29, 2025
Contributor
Author
|
The last commit added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing operations on the C++ interface:
Contextcopy-able and a wrapper constructor forlp_polynomial_context_tDyadicInterval(long)to avoid ambiguous implicit constructor callsDyadicRational(long), sinceDyadicRational(int)is present==,!=,<,<=,>, and>=betweenIntegerandlongto avoid unnecessary implicit construction ofIntegerobjects+=,-=, and*=as well as==,!=,<,<=,>, and>=betweenPolynomialandIntegerto avoid unnecessary construction ofPolynomialobjects with potentially incorrect context (partially fixes Operators are not context aware #97)