Skip to content

Fixed bounds calculcation #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmed-irfan merged 2 commits into from
Sep 27, 2024
Merged

Fixed bounds calculcation #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35ff4f9
Added missing case in infer_bounds
Ovascos Sep 27, 2024
0beea5e
Forgot about the duplicated code
Ovascos Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/polynomial/polynomial.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1524,7 +1524,7 @@ int lp_polynomial_constraint_infer_bounds(const lp_polynomial_t* A, lp_sign_cond
if (r) {
return r;
}
return lp_polynomial_constraint_infer_bounds(A, LP_SGN_LE_0, 0, M);
return lp_polynomial_constraint_infer_bounds(A, LP_SGN_GE_0, 0, M);
}
case LP_SGN_NE_0: // |x| - d != 0 => ?
return 0;
Expand Down Expand Up @@ -1743,7 +1743,7 @@ lp_polynomial_t* lp_polynomial_constraint_explain_infer_bounds(const lp_polynomi
if (p) {
return p;
}
return lp_polynomial_constraint_explain_infer_bounds(A, LP_SGN_LE_0, 0, x);
return lp_polynomial_constraint_explain_infer_bounds(A, LP_SGN_GE_0, 0, x);
}
case LP_SGN_NE_0: // |x| - d != 0 => ?
return 0;
Expand Down