Skip to content

Conversation

@andreboscatto
Copy link
Contributor

  • Adding email attribute to GenericUser;
  • Keeping mail and email (retro-compatibility) for LDAP tests while we standardize it. I'll open a new PR to remove the mail and keep it there to be merged after we deal with sssd tests.

@andreboscatto andreboscatto added Help wanted Extra attention is needed Question Further information is requested labels Mar 22, 2025
@andreboscatto
Copy link
Contributor Author

andreboscatto commented Mar 22, 2025

  • Need help to clean this branch from previous changes
  • Need to understand how to test the changes I made (I was unable to do it locally)
  • Need to validate if the attributes I changed are the right ones (specially for IPA which didn't have the email attribute before)

@andreboscatto andreboscatto changed the title Add email attribute to generic provider Add email attribute to GenericUser Mar 22, 2025
@danlavu
Copy link
Contributor

danlavu commented Mar 24, 2025

  • Need to understand how to test the changes I made (I was unable to do it locally)
cd ~/git/sssd_repository
pip uninstall sssd_test_framework
pip install -e ~/path/to/sssd_test_framework

-e = editable

Now you should be able to change the test code and have the attribute available to you.

@andreboscatto andreboscatto force-pushed the addEmailAttributeGenericProviders branch from d80bf04 to 824b493 Compare March 24, 2025 19:51
@andreboscatto andreboscatto reopened this Mar 25, 2025
@andreboscatto andreboscatto added Waiting for review and removed Help wanted Extra attention is needed Question Further information is requested labels Mar 25, 2025
@andreboscatto andreboscatto force-pushed the addEmailAttributeGenericProviders branch from 146b626 to 1b431f2 Compare March 25, 2025 20:09
@justin-stephenson justin-stephenson self-assigned this Mar 25, 2025
@madhuriupadhye
Copy link
Contributor

  • Need to understand how to test the changes I made (I was unable to do it locally)
cd ~/git/sssd_repository
pip uninstall sssd_test_framework
pip install -e ~/path/to/sssd_test_framework

-e = editable

Now you should be able to change the test code and have the attribute available to you.

You can also verify using git commit hash,
for ex,

(.venv) mupadhye@mupadhye-thinkpadp1gen4i:~/working/sssd/src/tests/system$ pip freeze | grep sssd-test-framework
-e git+ssh://git@github.com/madhuriupadhye/sssd-test-framework.git@8b02c318a37b71ad76367be9f1bac92e45862acc#egg=sssd_test_framework

here is my commit ID,

commit 8b02c318a37b71ad76367be9f1bac92e45862acc (HEAD -> id_override, origin/id_override)
Author: Madhuri Upadhye <mupadhye@redhat.com>
Date:   Tue Mar 4 12:36:40 2025 +0530

    IPA ID Override classes for users and groups

@jakub-vavra-cz
Copy link
Contributor

jakub-vavra-cz commented Mar 27, 2025

Hi wouldn't it be better to have email populated by default by username@domain ?
I would switch the logic around to enable not setting up an email but have it there by default.
We can extend authentication tests to use the email afterwards.

@andreboscatto
Copy link
Contributor Author

Hi @jakub-vavra-cz

I like the idea, but my suggestion is to do it in the "agile" way, with small increments. If this PR is sufficient for the purpose we need now, let's move ahead and merge it.

We can open a new issue/PR implementing your suggestion, wdyt? This way we don't keep this PR open for a long time while we discuss those details and set a final agreement/resolution (my PoV).

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can address default email in the future.

Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thank you.

Adding the email attribute to genericUser, IPA and LDAP. For LDAP we are
duplicating it (mail and email) for now. We will remove the mail
attribute later once all tests are refactored and replace mail by email.

Resolves: SSSD#160
@andreboscatto andreboscatto force-pushed the addEmailAttributeGenericProviders branch from 1b431f2 to b6906c6 Compare March 28, 2025 13:23
@andreboscatto andreboscatto merged commit e27b2c2 into SSSD:master Mar 28, 2025
5 checks passed
@andreboscatto andreboscatto deleted the addEmailAttributeGenericProviders branch March 28, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants