-
Notifications
You must be signed in to change notification settings - Fork 20
Add email attribute to GenericUser #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email attribute to GenericUser #161
Conversation
andreboscatto
commented
Mar 22, 2025
- Adding email attribute to GenericUser;
- Keeping mail and email (retro-compatibility) for LDAP tests while we standardize it. I'll open a new PR to remove the mail and keep it there to be merged after we deal with sssd tests.
|
-e = editable Now you should be able to change the test code and have the attribute available to you. |
d80bf04 to
824b493
Compare
146b626 to
1b431f2
Compare
You can also verify using git commit hash, here is my commit ID, |
|
Hi wouldn't it be better to have email populated by default by username@domain ? |
|
I like the idea, but my suggestion is to do it in the "agile" way, with small increments. If this PR is sufficient for the purpose we need now, let's move ahead and merge it. We can open a new issue/PR implementing your suggestion, wdyt? This way we don't keep this PR open for a long time while we discuss those details and set a final agreement/resolution (my PoV). |
jakub-vavra-cz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can address default email in the future.
justin-stephenson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, thank you.
Adding the email attribute to genericUser, IPA and LDAP. For LDAP we are duplicating it (mail and email) for now. We will remove the mail attribute later once all tests are refactored and replace mail by email. Resolves: SSSD#160
1b431f2 to
b6906c6
Compare