test: check is an2ln plugin is disabled or not #8145
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two new tests to verify the disabling of the 'an2ln' Kerberos localauth plugin in different environments (AD/IPA and LDAP). The tests check for the presence or absence of the localauth plugin configuration file and ensure that Kerberos TGT is available after logging in as a test user. I have identified a potential issue in the first test where the regular expression pattern might not be robust enough to handle variations in the path to the sssd_krb5_localauth_plugin.so module.
pbrezina
force-pushed
the
master
branch
2 times, most recently
from
f5d64b3 to
b854636
Compare
sumit-bose
force-pushed
the
disable_an2ln_test
branch
from
c78529a to
33fd8ac
Compare
|
|
||
| @pytest.mark.importance("critical") | ||
| @pytest.mark.topology(KnownTopology.LDAP) | ||
| def test_disable_an2ln_kdc(client: Client, provider: GenericProvider, kdc: KDC): |
There was a problem hiding this comment.
At the very least test name doesn't match what it does.
Test doesn't make sure 'an2ln' is disabled, it makes sure config snippet is absent.
And I'm not sure this test is really needed at all... imo, definitely not importance("critical")
There was a problem hiding this comment.
Hi,
I changed the name and made the importance "high". I think this test is important because we want to make sure the file isn't present in the plain krb5 case because it's creation cannot be disabled otherwise.
bye,
Sumit
sumit-bose
force-pushed
the
disable_an2ln_test
branch
from
33fd8ac to
aabb521
Compare
alexey-tikhonov
added
backport-to-sssd-2-9
backport-to-sssd-2-9-4
The Kerberos 'an2ln' localauth plugin should be disabled in AD and IPA environments where SSSD's localauth plugin can handle the mapping. In a plain Kerberos environment libkrb5 defaults should be used. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Alejandro López <allopez@redhat.com>
sssd-bot
force-pushed
the
disable_an2ln_test
branch
from
aabb521 to
80d5286
Compare
4 participants
The Kerberos 'an2ln' localauth plugin should be disabled in AD and IPA environments where SSSD's localauth plugin can handle the mapping. In a plain Kerberos environment libkrb5 defaults should be used.
Please note, this test is expected to fail until #8136 is commited.