Skip to content

krb5: fix OTP authentication #8296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justin-stephenson merged 2 commits into from
Dec 11, 2025
+7 −7
Merged

krb5: fix OTP authentication #8296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c754ce
krb5: fix OTP authentication
sumit-bose Dec 11, 2025
11fcc28
krb5_child: fix OTP authentication for PAM stacked tokens
ikerexxe Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/providers/krb5/krb5_child.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,8 @@ static krb5_error_code request_otp(krb5_context ctx,
goto done;
}

kr->otp = true;

for (i = 0; chl->tokeninfo[i] != NULL; i++) {
DEBUG(SSSDBG_TRACE_ALL, "[%zu] Vendor [%s].\n",
i, chl->tokeninfo[i]->vendor);
Expand All @@ -600,12 +602,9 @@ static krb5_error_code request_otp(krb5_context ctx,
/* Allocation errors are ignored on purpose */

DEBUG(SSSDBG_TRACE_ALL, "Setting otp prompting.\n");
if (kr->otp) {
kerr = k5c_attach_otp_info_msg(kr);
if (kerr != EOK) {
DEBUG(SSSDBG_CRIT_FAILURE,
"Failed to add otp prompting data.\n");
}
kerr = k5c_attach_otp_info_msg(kr);
if (kerr != EOK) {
DEBUG(SSSDBG_CRIT_FAILURE, "Failed to add otp prompting data.\n");
}

done:
Expand All @@ -625,7 +624,8 @@ static krb5_error_code answer_otp(krb5_context ctx,

type = sss_authtok_get_type(kr->pd->authtok);
if (type != SSS_AUTHTOK_TYPE_2FA_SINGLE
&& type != SSS_AUTHTOK_TYPE_2FA) {
&& type != SSS_AUTHTOK_TYPE_2FA
&& type != SSS_AUTHTOK_TYPE_PAM_STACKED) {
DEBUG(SSSDBG_MINOR_FAILURE, "Unexpected authentication token type [%s]\n",
sss_authtok_type_to_str(type));
return ERR_CHECK_NEXT_AUTH_TYPE;
Expand Down