[autobackport: sssd-2-9] cache_req: use sysdb_search_user_by_upn_with_view_res()

[sssd-bot]

This is an automatic backport of PR#7998 cache_req: use sysdb_search_user_by_upn_with_view_res() to branch sssd-2-9, created by @sumit-bose.

Caution

@sumit-bose The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr7998-to-sssd-2-9
git checkout SSSD-sssd-backport-pr7998-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr7998-to-sssd-2-9 --force

---

Original commits
794e80f - sysdb: add sysdb_search_user_by_upn_with_view_res()
43f22b9 - cache_req: use sysdb_search_user_by_upn_with_view_res()
fe61b85 - sysdb:: remove sysdb_getpwupn()
6d8f9d7 - tests: lookup user with overrides with email
6413f60 - tests: add IPA ID view test for user lookup by email

Backported commits

• 0d63b8a - sysdb: add sysdb_search_user_by_upn_with_view_res()
• 405598e - cache_req: use sysdb_search_user_by_upn_with_view_res()
• 8671c69 - sysdb:: remove sysdb_getpwupn()
• c008432 - tests: lookup user with overrides with email
• 90bf13c - CONFLICT! tests: add IPA ID view test for user lookup by email

Conflicting Files Information (check for deleted and re-added files)

• CONFLICT! tests: add IPA ID view test for user lookup by email

On branch SSSD-sssd-backport-pr7998-to-sssd-2-9
You are currently cherry-picking commit 6413f60b1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   src/tests/system/tests/test_ipa.py

no changes added to commit (use "git add" and/or "git commit -a")

---

Original Pull Request Body

To make sure any overrides are applied to the user even when searched by
UPN or email address sysdb_search_user_by_upn_with_view_res() is now used
in the cache request code.

[gemini-code-assist]

Code Review

This pull request backports the usage of sysdb_search_user_by_upn_with_view_res to ensure user overrides are applied when searching by UPN or email. The changes involve refactoring to use this new function and removing the old sysdb_getpwupn. The accompanying tests for both IPA ID views and local overrides are well-structured and correctly validate the new functionality. However, I've found a critical issue in the implementation of the new function sysdb_search_user_by_upn_with_view_res that could lead to incorrect lookup failures.

[gemini-code-assist]

The function may incorrectly return ENOENT if sysdb_add_overrides_to_object returns it, which happens when no override is found for a user. This would signal to the caller that the user was not found, even though the original user object was successfully retrieved. The function should return EOK if the user is found, regardless of whether overrides exist.

    return EOK;