Patch 2

[KanadeBlue]

Related issues & PRs

Changes

API changes

Behavioural changes

Backwards compatibility

Follow-up

Tests

Summary by CodeRabbit

• Chores

  • Updated automation workflows for Docker image builds and draft releases.
  • Enhanced internal string parsing across various components for improved robustness.

• Bug Fixes

  • Refined parsing and error messaging in configuration, command handling, language processing, and world generation.
  • Updated changelog documentation to highlight fixes addressing rendering issues, tool exceptions, and resource pack validations.

• New Features

  • Marked the build as stable.
  • Added a user-facing message encouraging prompt bug reporting.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates various GitHub Actions workflow versions and refines string parsing in the codebase. The changes include updating external action versions in GitHub workflows and adding a warning message in draft releases. Numerous PHP files now call explode() with an explicit limit (often using PHP_INT_MAX or a specific numeric value) to ensure predictable behavior. In addition, version extraction logic and build constants have been adjusted, and a new PHPStan rule is added to enforce proper explode() usage. Changelog sections have also been expanded.

Changes

File(s)	Change Summary
.github/workflows/build-docker-image.yml, .github/workflows/draft-release.yml	Updated GitHub Actions versions (Docker build and draft release) and added a bug-report warning message.
changelogs/5.25.md, phpstan.neon.dist	Added new changelog sections (5.25.1 & 5.25.2) and introduced a new PHPStan rule (ExplodeLimitRule).
build/dump-version-info.php, src/PocketMine.php, src/VersionInfo.php	Refined version extraction by adding an explode() limit and changed the development build constant to false.
src/{block/…/Sign.php, block/…/SignText.php, command/…, console/ConsoleCommandSender.php, item/LegacyStringToItemParser.php, lang/Language.php, network/mcpe/JwtUtils.php, permission/BanEntry.php, utils/{Config.php, Internet.php, Utils.php}, world/…/FlatGeneratorOptions.php}, tools/generate-bedrock-data-from-packets.php, tests/phpstan/rules/ExplodeLimitRule.php	Applied consistent explode() limit parameters across various methods; introduced PHP_INT_MAX where needed and added deprecation annotations where appropriate.

Poem

I'm Bunny, hopping through the code with delight,
Setting limits on strings to make parsing just right.
Workflows now sparkle with versions so new,
And warnings remind you to report bugs too.
With each little change, our garden grows bright—
🐰 A hop, skip, and jump, everything's feeling light!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f07e8dc and ed5d450.

⛔ Files ignored due to path filters (1)

• composer.lock is excluded by !**/*.lock

📒 Files selected for processing (23)

• .github/workflows/build-docker-image.yml (4 hunks)
• .github/workflows/draft-release.yml (2 hunks)
• build/dump-version-info.php (1 hunks)
• changelogs/5.25.md (1 hunks)
• phpstan.neon.dist (1 hunks)
• src/PocketMine.php (1 hunks)
• src/VersionInfo.php (1 hunks)
• src/block/tile/Sign.php (1 hunks)
• src/block/utils/SignText.php (1 hunks)
• src/command/Command.php (2 hunks)
• src/command/defaults/HelpCommand.php (2 hunks)
• src/command/defaults/ParticleCommand.php (1 hunks)
• src/console/ConsoleCommandSender.php (1 hunks)
• src/item/LegacyStringToItemParser.php (1 hunks)
• src/lang/Language.php (1 hunks)
• src/network/mcpe/JwtUtils.php (1 hunks)
• src/permission/BanEntry.php (1 hunks)
• src/utils/Config.php (5 hunks)
• src/utils/Internet.php (2 hunks)
• src/utils/Utils.php (1 hunks)
• src/world/generator/FlatGeneratorOptions.php (4 hunks)
• tests/phpstan/rules/ExplodeLimitRule.php (1 hunks)
• tools/generate-bedrock-data-from-packets.php (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.