Skip to content

Radium dataflow#1007

Closed
MathiasPaulin wants to merge 204 commits intoSTORM-IRIT:release-candidatefrom
MathiasPaulin:Radium-dataflow
Closed

Radium dataflow#1007
MathiasPaulin wants to merge 204 commits intoSTORM-IRIT:release-candidatefrom
MathiasPaulin:Radium-dataflow

Conversation

@MathiasPaulin
Copy link
Contributor

@MathiasPaulin MathiasPaulin commented Sep 29, 2022

Pull Request Desription

Add dataflow programming capabilities to the Radium engine (draft)

TODO

  • clarify ownership transfer of the nodes to the graph
  • clearly state that naked pointers got from the graph are non owning pointers.
  • add rendering component (NOT IN THIS PR)
  • add documentation and programming guide (WIP)
  • transform demos to unittests

Capture d’écran 2022-10-11 à 20 53 40

@MathiasPaulin MathiasPaulin added enhancement Type of issue/PR: enhancement Feature Request Type of issue: feature request WIP Work in Progress labels Sep 29, 2022
@MathiasPaulin MathiasPaulin requested a review from dlyr September 29, 2022 11:02
@MathiasPaulin MathiasPaulin force-pushed the Radium-dataflow branch 2 times, most recently from 177728c to 8a8a74f Compare September 29, 2022 18:49
@dlyr dlyr removed their request for review October 4, 2022 19:16
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1007 (daa40ef) into release-candidate (a349c0c) will increase coverage by 2.62%.
Report is 1 commits behind head on release-candidate.
The diff coverage is 71.13%.

❗ Current head daa40ef differs from pull request most recent head 305c81a. Consider uploading reports for the commit 305c81a to get more accurate results

@@                  Coverage Diff                  @@
##           release-candidate    #1007      +/-   ##
=====================================================
+ Coverage              45.65%   48.28%   +2.62%     
=====================================================
  Files                    312      351      +39     
  Lines                  23063    25722    +2659     
=====================================================
+ Hits                   10530    12420    +1890     
- Misses                 12533    13302     +769     
Files Changed Coverage Δ
src/Dataflow/Core/Enumerator.hpp 0.00% <0.00%> (ø)
...ataflow/QtGui/GraphEditor/ConnectionStatusData.hpp 0.00% <0.00%> (ø)
src/Dataflow/QtGui/GraphEditor/GraphEditorView.cpp 0.00% <0.00%> (ø)
...c/Dataflow/QtGui/GraphEditor/GraphEditorWindow.cpp 0.00% <0.00%> (ø)
...c/Dataflow/QtGui/GraphEditor/GraphEditorWindow.hpp 0.00% <0.00%> (ø)
...rc/Dataflow/QtGui/GraphEditor/NodeAdapterModel.cpp 0.00% <0.00%> (ø)
...rc/Dataflow/QtGui/GraphEditor/NodeAdapterModel.hpp 0.00% <0.00%> (ø)
src/Dataflow/QtGui/GraphEditor/WidgetFactory.cpp 0.00% <0.00%> (ø)
src/Dataflow/QtGui/GraphEditor/WidgetFactory.hpp 0.00% <0.00%> (ø)
src/Engine/Data/EnvironmentTexture.cpp 72.88% <ø> (ø)
... and 33 more

... and 2 files with indirect coverage changes

@MathiasPaulin MathiasPaulin force-pushed the Radium-dataflow branch 8 times, most recently from d658ada to 5597064 Compare October 17, 2022 14:08
@MathiasPaulin MathiasPaulin marked this pull request as ready for review October 20, 2022 15:03
Copy link
Contributor

@dlyr dlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review in progress

@MathiasPaulin MathiasPaulin force-pushed the Radium-dataflow branch 2 times, most recently from ee53b1d to 4023491 Compare November 2, 2022 11:46
@MathiasPaulin MathiasPaulin mentioned this pull request Nov 4, 2022
6 tasks
@dlyr dlyr marked this pull request as draft December 7, 2022 12:21
@MathiasPaulin MathiasPaulin force-pushed the Radium-dataflow branch 2 times, most recently from 6af0cfb to aae1e1d Compare February 27, 2023 11:25
dlyr added 28 commits September 20, 2023 18:04
Make data private and also use port shared ptr
BinaryOpNode
FilterNode
SingleDataSourceNode
Also start gather logging and new addLink with port only
move oneline in class definition
move template outside class definition in header
move bigger method in .cpp
reorder a bit
Add getter, and also reorder public/protected/private to have only one section of each.
Use more type alias
FindNode2 recurs on graph node
SinkNode and FonctionNode port getter
@dlyr dlyr mentioned this pull request Mar 26, 2025
4 tasks
@dlyr dlyr closed this Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Type of issue/PR: enhancement Feature Request Type of issue: feature request WIP Work in Progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants