Should store at a different key if this.props.localStorageKey

[hryanjones]

I can create a jsbin or something to demonstrate, but it appears that if the localStorageKey prop changes that it doesn't begin loading/saving to the new key.

If I'm understanding the code correctly, it not be too hard like adding a componentWillReceiveProps that reruns this.componentDidMount? I'll try to play around with this when I get a chance, but wanted to bring it up here in case you've seen this before.

[STRML]

You may want to create a jsbin - it checks the current value of props.localStorageKey, so there shouldn't be a problem here.

[STRML]

Do you expect it to actually re-load the data from the new key and setState() if it changes? That seems like an odd use case to me. You could, of course, implement it yourself in your components by adding a CWRP handler like:

componentWillReceiveProps(nextProps, nextState) {
  if (this.props.localStorageKey !== nextProps.localStorageKey) {
    LocalStorageMixin.componentDidMount.call(this);
  }
}

[hryanjones]

You may want to create a jsbin

I'll try to do that soon.

Do you expect it to actually re-load the data from the new key and setState() if it changes?

Yes, here's the example where I saw it:

• I'm working on a puzzle site that saves the puzzle state via the local storage mixin, this is the development version:
  • http://home.hryanjones.com:35729/adas/29/
  • Notice when you click to add some path into the example puzzle, that when you switch tabs to the larger puzzle that the paths are still there.
• I worked around this by just changing the this.props.key on the elements so that they'd be recreated when the puzzle was switched: http://hryanjones.com/adas/29/

I'm fine with my workaround, but I had expected it to work differently.