.navigate(href) is broken when called without a callback

[JoshSGman]

In the documentation, it states that you can navigate programmatically using the .navigate method on a reference to the router component instance. Unfortunately, the source code requires a second argument to be passed in the form a function yet it doesn't state this anywhere. If you don't pass any additional arguments, the setPath method breaks as it expects a "navigation" argument to be an object:

Environment.prototype.navigate = function navigate(path, navigation, cb) {
  if (typeof navigation === 'function' && cb === undefined) {
    cb = navigation;
    navigation = {};
  }
  return this.setPath(path, navigation, cb);
}

Environment.prototype.setPath = function(path, navigation, cb) {
  if (!navigation.isPopState) {
    if (navigation.replace) {
      this.replaceState(path, navigation);
    } else {
      this.pushState(path, navigation);
    }
  }
  this.path = path;
  this.notify(navigation, cb);
}

[STRML]

@JoshSGman Are you calling navigate on the Environment directly? While this is definitely a bug that should be fixed, I am wondering how you are doing this. See these lines in RouterMixin that prevent this.

[STRML]

Published fix as 0.20.3, but please let me know re: above.

[JoshSGman]

@STRML Thanks! The way I did it was as I understood it to be specified in the docs on the site.

I attached a ref to the Link, and then called

 this.refs.linkRef.navigate('/path') 

It looks like this ended up calling navigate on the Environment directly - with that said this was my understanding of how to route programmatically via the docs:

"Alternatively, if you have a reference to a router component instance, you can call its .navigate(href) method to do a transition to a different location. You can acquire a reference to a router by using React's Refs mechanism."

I wasn't looking to create an entire custom routing component.

[STRML]

Ah. What I take that to mean is a Router component (Locations) - not a Link component, although it appears that both work.

On Sep 16, 2014, at 10:38 AM, Joshua Goldberg notifications@github.com wrote:

@STRML Thanks! The way I did it was as I understood it to be specified in the docs on the site.

I attached a ref to the Link, and then called

this.refs.linkRef.navigate('/path')
It looks like this ended up calling navigate on the Environment directly - with that said this was my understanding of how to route programmatically via the docs:

"Alternatively, if you have a reference to a router component instance, you can call its .navigate(href) method to do a transition to a different location. You can acquire a reference to a router by using React's Refs mechanism."

I wasn't looking to create an entire custom routing component.

—
Reply to this email directly or view it on GitHub.