Open
Conversation
This patch refactors the lrbd codebase and makes it installable as a pypi package. Refactored the lrbd file into the lrbd directory: main.py - the main() with arguments host.py - all the host related methods/classes runtime.py - the Runtime object content.py - all the content related classes utils.py - all the utility functions Also reworked the unit tests and fixed a lot of hidden failures. The old nosetest runs were hiding a lot of failures that were exposed when you run the test_* files individually. Implemented a tox based unit test run syste and pep8 violations checks. tox -epy33 to run all the python 3 based unit tests tox -epep8 to run the pep8 violations checks
swiftgist
added a commit
that referenced
this pull request
Aug 13, 2018
Disable default portal, load modules
Contributor
|
@hemna Thanks a lot for your work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch refactors the lrbd codebase and makes it installable as
a pypi package.
Refactored the lrbd file into the lrbd directory:
main.py - the main() with arguments
host.py - all the host related methods/classes
runtime.py - the Runtime object
content.py - all the content related classes
utils.py - all the utility functions
Also reworked the unit tests and fixed a lot of
hidden failures. The old nosetest runs were
hiding a lot of failures that were exposed when
you run the test_* files individually.
Implemented a tox based unit test run syste and
pep8 violations checks.
tox -epy33 to run all the python 3 based unit tests
tox -epep8 to run the pep8 violations checks