fixed more maintainability issues

[OmarNabil005]

No description provided.

[Copilot]

Pull request overview

This PR addresses maintainability issues across the codebase, focusing on code quality improvements and adherence to best practices. The changes include modernizing Node.js imports, improving type safety, reducing code complexity, and removing unused dependencies.

Key changes:

• Modernized Node.js module imports to use the node: protocol
• Enhanced type safety by removing any type assertions and adding explicit type annotations
• Replaced .forEach() with for...of loops for better performance and readability

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/utils/otp.util.ts	Updated crypto import to use node:crypto protocol
src/users/users.service.ts	Added explicit type annotation to query result and removed any type assertions
src/user/user.service.ts	Removed unused UpdateUserDto import
src/storage/storage.service.ts	Updated path import to use node:path protocol and added readonly modifiers to class properties
src/profile/profile.service.ts	Replaced .forEach() loops with for...of loops
src/profile/profile.controller.ts	Removed unused Public decorator import
src/post/services/repost.service.ts	Removed unused NotFoundException import
src/post/services/redis-trending.service.ts	Added readonly modifiers to class properties and removed unnecessary non-null assertion
src/post/services/post.service.ts	Replaced .forEach() with for...of loop, simplified numeric literals, and improved string escaping
src/post/services/personalized-trends.service.ts	Simplified numeric literal from 1.0 to 1
src/post/post.controller.ts	Removed unused imports for file validation and Prisma types
src/messages/adapters/ws-auth.adapter.ts	Removed unused error parameter from catch block
src/auth/services/password/password.service.ts	Extracted URL construction into variables to reduce duplication
src/auth/auth.service.ts	Removed unused error parameter from catch block

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.