Describe the bug
If per-message profile fields are updated by m.replace relation event, sable continues to use the PMP info from the original event rather than the edited values.
Reproduction
- Send an event with PMP info (using
/usepmp)
- Manually send an event to edit the PMP fields in the first event using dev tools
Example (event from step 1 was $6fhyXHysyL_zz6XbD4WfcK1K-sgRgeYdjIj1n08pWwU, and had PMP displayname "olivia-prime"):
{
"body": "olivia-double-prime: test",
"com.beeper.per_message_profile": {
"displayname": "olivia-double-prime",
"has_fallback": true,
"id": "olivia-double-prime",
"io.fsky.nyx.pronouns": []
},
"format": "org.matrix.custom.html",
"formatted_body": "<strong data-mx-profile-fallback>olivia-double-prime: </strong>test",
"m.mentions": {},
"m.new_content": {
"body": "olivia-double-prime: test",
"com.beeper.per_message_profile": {
"displayname": "olivia-double-prime",
"has_fallback": true,
"id": "olivia-double-prime",
"io.fsky.nyx.pronouns": []
},
"format": "org.matrix.custom.html",
"formatted_body": "<strong data-mx-profile-fallback>olivia-double-prime: </strong>test",
"m.mentions": {},
"msgtype": "m.text"
},
"m.relates_to": {
"event_id": "$6fhyXHysyL_zz6XbD4WfcK1K-sgRgeYdjIj1n08pWwU",
"rel_type": "m.replace"
},
"msgtype": "m.text"
}
Expected behavior
I expect the edited message to show up with the new PMP displayname, but instead it still shows the original PMP displayname.
Platform and versions
1. OS: NixOS (Linux)
2. Browser: LibreWolf 146.0.1-1
2. Sable: v1.10.2 (a7c2ac3)
3. Homeserver: computer.surgery (grapevine 0.1.0 (1730cdb))
Additional context
The current MSC text does not explicitly call this out as an intended behavior, but I believe it is implied. I left a review comment there asking for this to be clarified.
Describe the bug
If per-message profile fields are updated by
m.replacerelation event, sable continues to use the PMP info from the original event rather than the edited values.Reproduction
/usepmp)Example (event from step 1 was
$6fhyXHysyL_zz6XbD4WfcK1K-sgRgeYdjIj1n08pWwU, and had PMP displayname "olivia-prime"):{ "body": "olivia-double-prime: test", "com.beeper.per_message_profile": { "displayname": "olivia-double-prime", "has_fallback": true, "id": "olivia-double-prime", "io.fsky.nyx.pronouns": [] }, "format": "org.matrix.custom.html", "formatted_body": "<strong data-mx-profile-fallback>olivia-double-prime: </strong>test", "m.mentions": {}, "m.new_content": { "body": "olivia-double-prime: test", "com.beeper.per_message_profile": { "displayname": "olivia-double-prime", "has_fallback": true, "id": "olivia-double-prime", "io.fsky.nyx.pronouns": [] }, "format": "org.matrix.custom.html", "formatted_body": "<strong data-mx-profile-fallback>olivia-double-prime: </strong>test", "m.mentions": {}, "msgtype": "m.text" }, "m.relates_to": { "event_id": "$6fhyXHysyL_zz6XbD4WfcK1K-sgRgeYdjIj1n08pWwU", "rel_type": "m.replace" }, "msgtype": "m.text" }Expected behavior
I expect the edited message to show up with the new PMP displayname, but instead it still shows the original PMP displayname.
Platform and versions
Additional context
The current MSC text does not explicitly call this out as an intended behavior, but I believe it is implied. I left a review comment there asking for this to be clarified.