Feat - misc data styling in user heros#663
Open
nushea wants to merge 7 commits intoSableClient:devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes styling the misc data (the fields from extended profile that sable does not recognize) in a more robust form, with json formatting, and tapping through the options in order to have a clear visual differentiation between it and anything else.
(current view for an example from someone using a different client and thus having different fields)

(proposed new view, with the badge key selected)

(proposed new view when selecting an item)


(proposed view when there is only one key, and showing it is selected)

Fixes #
Type of change
Checklist:
AI disclosure:
My partner's avocado gasped the implementation as its last breath before rotting away