-
Notifications
You must be signed in to change notification settings - Fork 18
File module remove refcounting #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tintin10q
wants to merge
9
commits into
SacBase:master
Choose a base branch
from
tintin10q:File-Module-Remove_Refcounting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
File module remove refcounting #238
tintin10q
wants to merge
9
commits into
SacBase:master
from
tintin10q:File-Module-Remove_Refcounting
+366
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordyAaldering
approved these changes
Jan 22, 2026
…ons into one file.
…ons into one file.
…ix it better later
6689477 to
2bd8d40
Compare
I did this through the web interface, I hope this works lol
tintin10q
commented
Jan 23, 2026
Contributor
Author
|
I have one more thing to add to this besides fixing the pipeline |
…ay we stay backwards compatible, and we have the best of both words. Programmers can get the status code of operations if they want too, but they are not forced to assign the result of the operations because a void version does exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.