major code restructuring #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors schema generation and testing in the Go codebase, with a focus on improving error handling, simplifying schema construction, and expanding test coverage for edge cases and recursive structures. The main logic for generating schemas is made more reusable, and tests are enhanced to ensure more robust and accurate schema generation.
Schema generation improvements:
genSchemamap inmain.goto use the newschematic.GenerateSchemafunction, simplifying schema definition and reducing redundancy.schematic.BuildEventsby replacinglog.Fatalfcalls with error returns usingfmt.Errorf, making the function more suitable for use as a library and easier to test. [1] [2]Testing enhancements:
TestGeneratePropertieswith several new, focused tests inschematic/generator_test.goto cover edge cases (such as maps, interfaces, time fields, byte slices, skipped fields, and unsigned integers), recursive structs, snake_case conversion, and required fields logic. This greatly increases test coverage and robustness of the schema generator. [1] [2]Other changes:
schematic/schema.jsonfile, as schema validation is now handled dynamically in tests rather than with a static file.