Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

fix: add @getter, @setter and @deleter to ID of parameters#1276

Merged
lars-reimann merged 5 commits intomainfrom
@gettter-also-at-parameters
Mar 16, 2023
Merged

fix: add @getter, @setter and @deleter to ID of parameters#1276
lars-reimann merged 5 commits intomainfrom
@gettter-also-at-parameters

Conversation

@Aclrian
Copy link
Contributor

@Aclrian Aclrian commented Mar 15, 2023

Closes #1277.

Summary of Changes

If the parent has a postfix like @getter, @setter or @deleter, the parameter will have it, too.

Testing Instructions

review created api_data.json and verify that every ID is unique.

@lars-reimann
Copy link
Member

lars-reimann commented Mar 15, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON eslint-plugin-jsonc 2 0 0 17.27s
✅ JSON jsonlint 2 0 0.7s
✅ JSON npm-package-json-lint yes no 0.44s
✅ JSON prettier 2 0 0 13.99s
✅ JSON v8r 2 0 1.56s
✅ PYTHON black 1 0 0 1.11s
✅ PYTHON flake8 1 0 0.34s
✅ PYTHON isort 1 0 0 1.72s
✅ PYTHON mypy 1 0 1.95s
✅ PYTHON pylint 1 0 4.76s
✅ REPOSITORY git_diff yes no 0.58s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Merging #1276 (e6141a1) into main (cc5613e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
- Coverage   66.41%   66.40%   -0.01%     
==========================================
  Files         168      168              
  Lines        7187     7188       +1     
  Branches      596      596              
==========================================
  Hits         4773     4773              
- Misses       2145     2146       +1     
  Partials      269      269              
Components Coverage Δ
backend 81.66% <ø> (ø)
desktop 2.65% <ø> (ø)
gui 43.03% <ø> (ø)
package-parser 75.54% <0.00%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...rser/package_parser/processing/api/_ast_visitor.py 21.33% <0.00%> (-0.15%) ⬇️

@lars-reimann lars-reimann changed the title feat: add @getter, @setter and @deleter to parameters fix: add @getter, @setter and @deleter to parameters Mar 15, 2023
@Aclrian Aclrian changed the title fix: add @getter, @setter and @deleter to parameters fix: add @getter, @setter and @deleter to ID of parameters Mar 15, 2023
@Aclrian Aclrian marked this pull request as ready for review March 15, 2023 20:02
@Aclrian Aclrian requested a review from lars-reimann as a code owner March 15, 2023 20:02
@Aclrian Aclrian added this pull request to the merge queue Mar 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 16, 2023
@lars-reimann lars-reimann added this pull request to the merge queue Mar 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Mar 16, 2023
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@lars-reimann lars-reimann added this pull request to the merge queue Mar 16, 2023
@lars-reimann lars-reimann removed this pull request from the merge queue due to a manual request Mar 16, 2023
@lars-reimann lars-reimann merged commit a76d2f9 into main Mar 16, 2023
@lars-reimann lars-reimann deleted the @gettter-also-at-parameters branch March 16, 2023 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicated Parameter ID

3 participants