This repository was archived by the owner on Jan 19, 2025. It is now read-only.
fix: add @getter, @setter and @deleter to ID of parameters#1276
Merged
lars-reimann merged 5 commits intomainfrom Mar 16, 2023
Merged
fix: add @getter, @setter and @deleter to ID of parameters#1276lars-reimann merged 5 commits intomainfrom
@getter, @setter and @deleter to ID of parameters#1276lars-reimann merged 5 commits intomainfrom
Conversation
Member
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report
@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
- Coverage 66.41% 66.40% -0.01%
==========================================
Files 168 168
Lines 7187 7188 +1
Branches 596 596
==========================================
Hits 4773 4773
- Misses 2145 2146 +1
Partials 269 269
|
@getter, @setter and @deleter to parameters@getter, @setter and @deleter to parameters
@getter, @setter and @deleter to parameters@getter, @setter and @deleter to ID of parameters
You're not authorized to push to this branch. Visit "About protected branches" for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1277.
Summary of Changes
If the parent has a postfix like
@getter,@setteror@deleter, the parameter will have it, too.Testing Instructions
review created api_data.json and verify that every ID is unique.